Fix prometheus http_proxy using 0.0.0.0:80 #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `VMDB::Util.http_proxy_uri` is `nil`
`VMDB::Util.http_proxy_uri.to_s` is `""`.
With uri v0.10.3 `URI.parse("http://")` would have a `host` of `nil` but
on v0.13.0 `URI.parse("http://")` has a `host` of `""`.
This was causing Faraday to use a proxy of `0.0.0.0:80` instead of none.
Fryguy
approved these changes
Mar 5, 2024
|
Checked commit agrare@fb18d4b with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
|
Backported to |
Fryguy
added a commit
that referenced
this pull request
Mar 5, 2024
Fix prometheus http_proxy using 0.0.0.0:80 (cherry picked from commit 22d854f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
VMDB::Util.http_proxy_uriisnilVMDB::Util.http_proxy_uri.to_sis"".With uri v0.10.3
URI.parse("http://")would have ahostofnilbut on v0.13.0URI.parse("http://")has ahostof"".This was causing Faraday to use a proxy of
0.0.0.0:80instead of none.prometheus-api-client-0.6.2/lib/prometheus/api_client/client.rb:106:in 'rescue in run_command': Failed to open TCP connection to :80 (Connection refused - connect(2) for 0.0.0.0:80) (Prometheus::ApiClient::Client::RequestError)